Fix possible KeyError#173
Closed
roelandvanbatenburg wants to merge 1 commit intonccgroup:masterfrom
roelandvanbatenburg:fix_possible_KeyError
Closed
Fix possible KeyError#173roelandvanbatenburg wants to merge 1 commit intonccgroup:masterfrom roelandvanbatenburg:fix_possible_KeyError
roelandvanbatenburg wants to merge 1 commit intonccgroup:masterfrom
roelandvanbatenburg:fix_possible_KeyError
Conversation
houllette
pushed a commit
to sobelow/sobelow
that referenced
this pull request
May 8, 2025
Contributor
|
Hey @roelandvanbatenburg - sorry for the delay on this; for reasons explained in another issue (#180), I've created an official fork and I'm folding in this PR over there and giving you attribution. Feel free to close out this PR and follow progress over in the new repo here from now on! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed this while upgrading to Elixir 1.18 from the new type system (see below).
Sobelow.get_mod/1can returnnil, so we should account for that.